feat: vllm metrics pulled from backend #4134
Draft
+233
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daiyaanarfeen
changed the title
Signed-off-by: Daiyaan <[email protected]>
daiyaanarfeen
force-pushed
the
darfeen/migrate-planner-metrics
branch
from
8240a72 to
3ae056d
Compare
Signed-off-by: Daiyaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Changes Planner so it collects backend metrics instead of frontend metrics to decide whether to scale
Details:
Planner prometheus client searches for backend metrics when using vLLM, otherwise defaults to frontend metrics
Where should the reviewer start?
components/src/dynamo/planner/utils/planner_core.py
components/src/dynamo/planner/utils/prometheus.py
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)